chore: skip critical process monitoring on VS#24644
Open
cyw233 wants to merge 1 commit into
Open
Conversation
Skip process_monitoring/test_critical_process_monitoring.py::test_monitoring_critical_processes on VS when sonic-buildimage issue 10336 is active while preserving the existing xfail for other platforms. Signed-off-by: Chenyang Wang <chenyangw233@gmail.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
github-actions
Bot
requested review from
BYGX-wcr,
xwjiang-ms and
yutongzhang-microsoft
cyw233
changed the title
Contributor
Author
|
Duplicated with #24077 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Add a VS-specific conditional skip for
process_monitoring/test_critical_process_monitoring.py::test_monitoring_critical_processeswhen sonic-buildimage issue 10336 is active.The test was already marked
xfailwhile the issue is active. This PR keeps that behavior for all platforms, and adds a narrowerskipmark for VS so VS runs do not execute the known failing test while the issue remains open.Fixes # (issue): N/A
Related issue: sonic-net/sonic-buildimage#10336
Type of change
Back port request
Approach
What is the motivation for this PR?
test_monitoring_critical_processesis affected by sonic-buildimage issue 10336, causingtest_monitoring_critical_processesto hang until timeout in the PR checker. The existing conditional mark xfails the test for all platforms while the issue is active. VS needs to skip the test entirely for the same active issue.How did you do it?
Added a
skipmark to the existing conditional mark entry fortest_monitoring_critical_processeswith two required conditions:asic_type in ['vs']https://github.com/sonic-net/sonic-buildimage/issues/10336The existing issue-gated
xfailremains unchanged for non-VS platforms.How did you verify/test it?
Verified the YAML parses successfully and that the new skip entry contains both required conditions.
Any platform specific information?
The new skip applies only to VS ASIC type. Non-VS platforms continue to use the existing conditional xfail while issue 10336 is active.
Supported testbed topology if it's a new test case?
N/A.
Documentation
N/A.