[BMC] Skip disk/test_disk_exhaustion on BMC topology#24654
Open
Gfrom2016 wants to merge 1 commit into
Open
Conversation
Skip disk/test_disk_exhaustion.py on BMC topologies. The test validates that with /var (root disk) deliberately exhausted, the SONiC data plane still forwards packets end-to-end. It requires a PortChannel with a peer IP from the minigraph (line 72-76, file 'tests/disk/test_disk_exhaustion.py') and uses ptfadapter to inject/verify packets through that PortChannel. BMC platforms have no front-panel ports and no PortChannels in the minigraph, so 'minigraph_portchannel_interfaces' is empty, peer_ip_ifaces_pair is [], and line 100 (peer_ip_ifaces_pair[0][1][0]) raises IndexError. Even past that line the rest of the test cannot do anything meaningful -- there is no data plane on BMC to validate under disk pressure. Add a skip entry alongside the existing IPv6 xfail entry, gated on 'bmc' in topo_type. Matches the dozens of similar BMC-specific skips already in this file. Signed-off-by: zitingguo <zitingguo@microsoft.com>
Collaborator
|
/azp run |
github-actions
Bot
requested review from
BYGX-wcr,
xwjiang-ms and
yutongzhang-microsoft
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
Review note (non-blocking):
AI agent on behalf of Ying. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: skip
disk/test_disk_exhaustion.pyon BMC topologies.The test validates that with
/var(root disk) deliberately exhausted, the SONiC data plane still forwards packets end-to-end. It requires a PortChannel with a peer IP from the minigraph (construct_packet_and_get_params, lines 72-76 intests/disk/test_disk_exhaustion.py) and usesptfadapterto inject/verify packets through that PortChannel.BMC platforms have no front-panel ports and no PortChannels in the minigraph. So:
mg_facts["minigraph_portchannel_interfaces"]is emptypeer_ip_pc_pair = []peer_ip_ifaces_pair = []peer_ip_ifaces_pair[0][1][0]→IndexError: list index out of rangeEven if we got past that line, the rest of the test cannot do anything meaningful — there is no data plane on BMC to validate under disk pressure.
The new
skipis added alongside the existing IPv6xfail, matching the dozens of similar BMC-specific skips elsewhere in this file.Type of change
Back port request
Approach
What is the motivation for this PR?
test_disk_exhaustionfails withIndexError: list index out of rangeat line 100 on Komodo BMC (arm64-nexthop_b27-r0) in every baseline run (R1, R2, R3). The test is fundamentally a data-plane test; BMC has no data plane.How did you do it?
Added a
skipblock to the existingdisk/test_disk_exhaustion.pyentry intests/common/plugins/conditional_mark/tests_mark_conditions.yaml, gated on"'bmc' in topo_type".How did you verify/test it?
python3 -c "import yaml; yaml.safe_load(open(...))"confirms the YAML parses clean.tests/disk/test_disk_exhaustion.pyindexing an empty list.Any platform specific information?
Only BMC topologies (
'bmc' in topo_type). No effect on switching platforms.Supported testbed topology if it's a new test case?
N/A.
Documentation
N/A.