[bgp]: Fix BGP aggregate-address placeholder prefix rejected by FRR#24655
Open
Guoyuan001 wants to merge 2 commits into
Open
[bgp]: Fix BGP aggregate-address placeholder prefix rejected by FRR#24655Guoyuan001 wants to merge 2 commits into
Guoyuan001 wants to merge 2 commits into
Conversation
Signed-off-by: Guoqiang Yuan <guoyuan@microsoft.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
1 similar comment
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+97
to
+98
| r".* ERR iptables: tac_connect_single: connection to .* failed: " | ||
| r"Network is unreachable.*", |
shixizhang
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
The PLACEHOLDER_PREFIX used by the BGP aggregate-address tests was
defined as a host route 192.0.2.0/32. FRR rejects aggregate-address entries
whose prefix length is too specific
Type of change
Back port request
Approach
What is the motivation for this PR?
Unblock tests/bgp/test_bgp_aggregate_address.py and
tests/bgp/test_bgp_aggregate_address_scale_stress.py, which were failing at
configuration time because FRR refused the /32 placeholder aggregate prefix.
How did you do it?
Changed PLACEHOLDER_PREFIX in tests/bgp/bgp_aggregate_helpers.py from
192.0.2.0/32 to 192.0.2.0/24 (still inside the RFC 5737 TEST-NET-1
documentation block, so it cannot collide with real routing) and added a
comment explaining the FRR constraint.
test_bgp_aggregate_address.py and test_bgp_aggregate_address_scale_stress.py
and imported the single source of truth from bgp_aggregate_helpers.
How did you verify/test it?
Test it on DUT
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation