This repository was archived by the owner on Aug 31, 2022. It is now read-only.
Add some new testcases to dialin and dialout mode#28
Open
MuLinForest wants to merge 2 commits intosonic-net:masterfrom
Open
Add some new testcases to dialin and dialout mode#28MuLinForest wants to merge 2 commits intosonic-net:masterfrom
MuLinForest wants to merge 2 commits intosonic-net:masterfrom
Conversation
* In gnmi_server/server_test.go Add getting queues tests and non-db data test. TestGnmiGET: * Get COUNTERS:Ethernet68 Queues * Get COUNTERS (use vendor alias):Ethernet68/1 Queues * Get COUNTERS:Ethernet* Queues * get non-db platform cpu TestGnmiSubscribe: * poll query for platform/cpu * In dialout/dialout_client/dialout_client_test.go Add periodic report type test * DialOut to first collector in periodic mode (COUNTERS_PORT_NAME_MAP) * DialOut to first collector in periodic mode (COUNTERS/Ethernet*) * DialOut to second collector in periodic mode upon failure of first collector (COUNTERS/Ethernet68/Queues) * DialOut to second collector in periodic mode upon failure of first collector (platform/cpu)
Contributor
Author
|
@hui-ma hi, could you please help to review |
pra-moh
reviewed
May 19, 2020
| Response: &pb.SubscribeResponse_Update{ | ||
| Update: &pb.Notification{ | ||
| //Timestamp: GetTimestamp(), | ||
| //Prefix: prefix, |
Contributor
Author
There was a problem hiding this comment.
Thank you, it is removed.
pra-moh
reviewed
May 19, 2020
gnmi_server/server_test.go
Outdated
| elem: <name: "COUNTERS" > | ||
| elem: <name: "Ethernet68" > | ||
| elem: <name: "Queues" > | ||
| `, |
Contributor
Author
There was a problem hiding this comment.
Thank you, it is removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add getting queues tests and non-db data test. Since the non-db data could not be known in advance, so the return data is removed and it only compares with the path to verify.
Add periodic report type test. The non-db response is verified by path. Therefore, I add a new function to compare the path.