This repository was archived by the owner on Aug 31, 2022. It is now read-only.
Open
Conversation
pra-moh
reviewed
Aug 12, 2020
hui-ma
reviewed
Aug 13, 2020
Collaborator
|
what test have been conducted for this change? And does all utest still work? |
Insecure flag has been reverted back to corresponding with tlsCfg.InsecureSkipVerify and created a new flag, "tls_disable" for the new tlsDisable option.
Fixing sample collector code. Missed declaration, missed exclamation point.
Author
The change is to the command line arguments only. The change is not reflected in the CONFIG_DB. See #43 which is a new PR to add documentation for the command line arguments for more information. |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Adds support for insecure mode for testing and development purposes to telemetry dial-out. Based on the changes authored by @liuqu in PR #14 .
Previously -insecure failed to connect to collectors running on windows systems, but this fixes this issue.
Dial-out client: Fixes insecure mode