This repository was archived by the owner on Aug 31, 2022. It is now read-only.
Add reportType "once" in function publishRun of dialout_client.go#85
Open
MuLinForest wants to merge 1 commit intosonic-net:masterfrom
Open
Add reportType "once" in function publishRun of dialout_client.go#85MuLinForest wants to merge 1 commit intosonic-net:masterfrom
MuLinForest wants to merge 1 commit intosonic-net:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
reportType in dialout_client.go is defined as Unknown, Once, Periodic or Stream.
But in function publishRun, "case Once" is miss from "switch cs.reportType".
How I did it
Complete this missing case.