Major change in code internals

[PBarmby]

Hi Sophia -- I was trying to use imagecube with Sahar's data and not being very successful. For what I needed to do, a different file structure was necessary, so I rewrote the code to have 2 output files: a multi-extension FITS file which contains the processed images, and a separate 3D datacube file (see OUTPUT in the help for the main imagecube file). This makes it easier to run one task at a time and also allowed me to simplify the code somewhat. I put in a few more bells and whistles, like adding information to HISTORY cards in the header.

You may want to have a look at the changes in detail (you could clone my file_struct branch if you like) before merging. We can also talk about it over Skype if you like..

[sophiathl]

Hi Pauline, how about skype this Friday, about London's morning (our time
difference now is 6 hours)? Or over the weekend, when I am in Athens (7
hours)? Or perhaps when you are back, end of July? Anything is OK with me.

On Wed, Jul 2, 2014 at 3:26 AM, Pauline Barmby notifications@github.com
wrote:

Hi Sophia -- I was trying to use imagecube with Sahar's data and not being
very successful. For what I needed to do, a different file structure was
necessary, so I rewrote the code to have 2 output files: a multi-extension
FITS file which contains the processed images, and a separate 3D datacube
file (see OUTPUT in the help for the main imagecube file). This makes it
easier to run one task at a time and also allowed me to simplify the code
somewhat. I put in a few more bells and whistles, like adding information
to HISTORY cards in the header.

You may want to have a look at the changes in detail (you could clone my
file_struct branch if you like) before merging. We can also talk about it

over Skype if you like..

You can merge this Pull Request by running

git pull https://github.com/PBarmby/imagecube file_struct

Or view, comment on, or merge it at:

#8
Commit Summary

• starting to work on new file structure
• Initial change to hdulist file structure, untested.
• Fixed indentation; cleanup still works.
• construct_mef now works
• convert_image now works
• switched cleanup function
• register_image in progress, not yet working
• fixes to resample_image (as yet untested)
• switched over convolve_image, untested
• convolve_image seems to work
• resample_image appears to work
• create_datacube nearly but not quite working
• resample_image works
• still problems with register_image, create_datacube
• merge_headers was overwriting input: fixed. This fixes
  register_image and resample_image too, I think.
• create_datacube works
• test_imagecube now passes
• added comments to code, more info to output headers
• tiny changes
• fixed check on imagecube history
• minor bug fix
• Existing imagecube.fits not included in input
• changed datacube creation to use dstack and swapaxes
• changed im_regrid to im_resamp (less confusion with im_reg)
• changed introductory info

File Changes

• M imagecube/imagecube.py
  https://github.com/sophiathl/imagecube/pull/8/files#diff-0 (697)
• M imagecube/tests/test_imagecube.py
  https://github.com/sophiathl/imagecube/pull/8/files#diff-1 (48)

Patch Links:

• https://github.com/sophiathl/imagecube/pull/8.patch
• https://github.com/sophiathl/imagecube/pull/8.diff

—
Reply to this email directly or view it on GitHub
#8.