Open
Conversation
- Added @xterm/addon-unicode11 dependency to package.json. - Updated SCSS imports in bootstrap.scss to use tilde (~) for proper path resolution. - Modified xterm.tsx to include Unicode11Addon and set active version to '11'. - Adjusted webpack.config.js to use path.resolve for includePaths in sass-loader options. SCSS import and webpack changes are to fix Docker building. The rest - for rendering emoji correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In newest versions of chrome, if emojis are present in the terminal, their width does not get computed properly, leading to character width sensitive applications to have inconsistent spacing.
Before fix:
After fix:
SCSS import and webpack changes are to fix Docker building.
The rest - for rendering emoji correctly.
Tested and working - GoTTY now correctly determines emoji character spacing.