Remove unused files and add Microsoft Defender workflow#26
Conversation
…e mappings for behavioral and physiological data
This workflow integrates Microsoft Security DevOps for static analysis in the development cycle, triggered on push, pull request, and scheduled events.
…vice account JSON credentials (do not track these in Git)
…n permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Added a security policy document outlining supported versions and vulnerability reporting.
…e-issue Add explicit Gemini Code Assist org-setup guidance to README
Implementing features enhancement
…nect emulator lifecycle
Signed-off-by: Alice Severi Gonçalves <223510749+sothiss@users.noreply.github.com>
Signed-off-by: Alice Severi Gonçalves <223510749+sothiss@users.noreply.github.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a comprehensive suite of Firebase agent skills, reference guides, and development environment configurations (including EthoPipe workflows and devcontainer setups). The review feedback identifies several critical issues across the new documentation files: a variable shadowing bug in the Android Auth SDK guide that leaves a property uninitialized, untracked environment directories (node_modules/ and .vs/) that need to be ignored in .gitignore, a syntax error and an undefined variable reference in the Web AI Logic patterns, and escaped string interpolation characters in the Flutter Auth setup that prevent proper error logging.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
|
||
| override fun onCreate(savedInstanceState: Bundle?) { | ||
| super.onCreate(savedInstanceState) | ||
| val auth = Firebase.auth |
There was a problem hiding this comment.
Redeclaring auth as a local variable with val auth inside onCreate shadows the class property private lateinit var auth: FirebaseAuth. This leaves the class property uninitialized, which will cause an UninitializedPropertyAccessException when auth is accessed in onStart().
| val auth = Firebase.auth | |
| auth = Firebase.auth |
| # GCP Service Account credentials (never commit these!) | ||
| *service-account*.json | ||
| *serviceaccount*.json | ||
| *credentials*.json |
There was a problem hiding this comment.
The node_modules/ and .vs/ directories are currently being committed to the repository (as seen in the file list). They are environment-specific and should never be tracked by Git. Please add them to .gitignore and run git rm -r --cached node_modules/ .vs/ to untrack them.
# GCP Service Account credentials (never commit these!)
*service-account*.json
*serviceaccount*.json
*credentials*.json
# Dependency directories
node_modules/
# IDE settings
.vs/
| generationConfig: { | ||
| responseMimeType: "application/json", | ||
| // Optional: Define a schema | ||
| schema = Schema.object({ ... }); |
There was a problem hiding this comment.
In JavaScript/TypeScript, using an assignment operator (=) and a semicolon inside an object literal is a syntax error. It should be a colon (:) and no semicolon.
| schema = Schema.object({ ... }); | |
| schema: Schema.object({ ... }) |
|
|
||
| // Initialize the AI Logic service (defaults to Gemini Developer API) | ||
| // To set the AI provider, set the backend as the second parameter | ||
| const ai = getAI(firebaseApp, { backend: new GoogleAIBackend() }); |
There was a problem hiding this comment.
The variable firebaseApp is undefined. It should be app to match the initialized Firebase App instance on line 17.
| const ai = getAI(firebaseApp, { backend: new GoogleAIBackend() }); | |
| const ai = getAI(app, { backend: new GoogleAIBackend() }); |
| return await _auth.signInWithCredential(credential); | ||
| } | ||
| } catch (e) { | ||
| print("Error during Google Sign-In: \$e"); |
There was a problem hiding this comment.
Escaping the $ sign (\$e) inside a double-quoted string literal in Dart prevents string interpolation, causing it to print the literal string "$e" instead of the actual caught exception. Remove the backslash to correctly interpolate the error.
| print("Error during Google Sign-In: \$e"); | |
| print("Error during Google Sign-In: $e"); |
| } | ||
| await _auth.signOut(); | ||
| } catch (e) { | ||
| print("Error signing out: \$e"); |
There was a problem hiding this comment.
Escaping the $ sign (\$e) inside a double-quoted string literal in Dart prevents string interpolation, causing it to print the literal string "$e" instead of the actual caught exception. Remove the backslash to correctly interpolate the error.
| print("Error signing out: \$e"); | |
| print("Error signing out: $e"); |
No description provided.