Fix dom ready issue#67
Open
bitinn wants to merge 2 commits into
Open
Conversation
sc0ttj
added a commit
to sc0ttj/sketch.js
that referenced
this pull request
Mar 4, 2021
Fix soulwire#50, by not using doc.body until Sketch.create() is called. Note that you still need the DOM ready for Sketch.create() to work from soulwire#67
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #50, by not using
doc.bodyuntilSketch.create()is called.Note that you still need dom ready for
Sketch.create()to work, I updated the drawing example to demonstrate this requirement.Both test cases and demos have been ran successfully to confirm this change is working.
PS: given both
windowanddocumentare in global context, I find passing boththisandthis.documenta bit unnecessary, so clean that up a bit as well.