preserve original event when eventTarget is used#97
Open
nikrowell wants to merge 2 commits into
Open
Conversation
|
Good job, nikrowell! This's exactly what I'm looking for. preventDefault() makes using document.body for eventTarget actually meaningless. There are cases where we want to preventDefault() or not judging by the eventType or the srcElement, better let developers to handle that rather than simply prevent all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using document.body (or anything other than the default canvas) for eventTarget will hijack the original event. This change checks if the eventTarget is the canvas element before calling preventDefault(). I tried adding a test but getting Cannot simulate touch events - use examples to validate functinality in Chrome.
Easy to verify in the drawing example: with
eventTarget: document.body, moves movements underneath the info panel continue painting and clicking "View on Github" follows the link.