Implement Dark Mode Toggle for the Notes App #9
Open
Priyakatariya wants to merge 1 commit intosoumya813:mainfrom
Open
Implement Dark Mode Toggle for the Notes App #9Priyakatariya wants to merge 1 commit intosoumya813:mainfrom
Priyakatariya wants to merge 1 commit intosoumya813:mainfrom
Conversation
soumya813
reviewed
Jun 17, 2025
Owner
soumya813
left a comment
There was a problem hiding this comment.
Thanks for the PR! I appreciate your effort in adding the dark mode toggle. However, I noticed a few concerns
-the current implementation removes the existing pink theme entirely, which we want to keep as the default.
-Also, the dark mode styling feels too generic and doesn’t align with the soft, aesthetic vibe of the app.
-The code appears to be fully ai generated.
I’d suggest keeping the original theme intact, refining the dark mode to better match the app’s mood, and restructuring the code to stay consistent with the rest of the project.
Let me know if you need any help with this, happy to guide!
Author
|
I send you this just to know what type of google effect you want but now I
fix everything accordingly you mention
…On Tue, 17 Jun 2025, 10:12 am Soumya Srivastav, ***@***.***> wrote:
***@***.**** commented on this pull request.
Thanks for the PR! I appreciate your effort in adding the dark mode
toggle. However, I noticed a few concerns
-the current implementation removes the existing pink theme entirely,
which we want to keep as the default.
-Also, the dark mode styling feels too generic and doesn’t align with the
soft, aesthetic vibe of the app.
-The code appears to be fully ai generated.
I’d suggest keeping the original theme intact, refining the dark mode to
better match the app’s mood, and restructuring the code to stay consistent
with the rest of the project.
Let me know if you need any help with this, happy to guide!
—
Reply to this email directly, view it on GitHub
<#9 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BMGHVRMSO3IVEANLNLBQBQT3D6MC7AVCNFSM6AAAAAB7JYEN6WVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDSMZUGEYDSNJZGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔧 Key Changes:
Added a 🌙/🌞 toggle button in the navigation bar (header.ejs) to switch between Light and Dark themes.
Applied CSS variables for theming (main.css), allowing consistent and easy style switching.
User theme preference is stored in localStorage to persist the mode across sessions.
Smooth transition animations between themes for better UX.
Updated styles to ensure all elements (backgrounds, text, cards, forms, links) adapt properly in both themes.
http://localhost:5000/