Merged
Conversation
Originally done in f1cf593. Amended to fix some bugs with types. --------- Co-authored-by: Lee Yi <leeyi45@gmail.com>
Type errors will be fixed later.
Done to align with where the action creator is located.
Original implementation in bbf4f09. Adapted to match current state of codebase. --------- Co-authored-by: Lee Yi <leeyi45@gmail.com>
Also added a TODO for a testing util.
Contributor
|
Turns out |
Pull Request Test Coverage Report for Build 8937016269Details
💛 - Coveralls |
Member
Author
Thanks! My bad, I missed out the fact that |
Some are left unmigrated to preserve the readability of the diff.
Only updated sagas that require a simple fix of the imported action types. Remaining sagas will be done in a later commit.
To minimise potentially unnecessary development effort while pending removal decision outcome. Only commented handlers that are incompatible with the type changes.
Use the action creator instead of creating the action object manually to enforce abstraction.
RichDom2185
commented
May 3, 2024
Intentionally done in a very specific way, mixing new and old code styles, in order to keep the diff legible for such a large migration. Further refactoring will be done in the future.
chownces
approved these changes
May 3, 2024
RichDom2185
commented
May 3, 2024
Member
Author
RichDom2185
left a comment
RichDom2185
left a comment
There was a problem hiding this comment.
Tested locally and everything still works, will merge now and make the rest of the changes in subsequent parts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Based on @leeyi45's work done in #2874.
Intentionally split and only migrated some stuff to keep the diff readable.
I strongly recommend going through the changes commit by commit instead of going through the full diff of this PR. Please refer to the commit history for a list of changes.
Type of change
How to test
Everything should still work. Tests involving
createStoreare still failing at the moment, will fix in the next few days.Checklist