Fix crash when stored playground language state is invalid#3646
Open
martin-henz wants to merge 3 commits intomasterfrom
Open
Fix crash when stored playground language state is invalid#3646martin-henz wants to merge 3 commits intomasterfrom
martin-henz wants to merge 3 commits intomasterfrom
Conversation
Validate the stored chapter+variant combination against ALL_LANGUAGES when loading from localStorage. Falls back to the default language config if the combination is invalid (e.g. chapter 1 + explicit-control). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
RichDom2185
requested changes
Mar 10, 2026
Member
RichDom2185
left a comment
RichDom2185
left a comment
There was a problem hiding this comment.
This works but behaves differently than what the issue suggests.
Pull Request Test Coverage Report for Build 22934474185Details
💛 - Coveralls |
7 tasks
Member
Author
In what way is this different from what the issue suggests? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI-generated PR, fixing #3645
Generated with Claude Code, Sonnet 4.6.
Description
Validate the stored chapter+variant combination against ALL_LANGUAGES when loading from localStorage. Falls back to the default language config if the combination is invalid (e.g. chapter 1 + explicit-control).
Type of change
How to test
Start frontend using localhost, switch to conductor in feature flags, choose Source 1. Then reload in the browser. This would crash the frontend when the feature flag is reset to false, because the "Source 1" language does not have a CSE machine implementation.
Checklist