QOL: Arrows bending too early or too late#3653
Open
RogerZhang888 wants to merge 21 commits intosource-academy:masterfrom
Open
QOL: Arrows bending too early or too late#3653RogerZhang888 wants to merge 21 commits intosource-academy:masterfrom
RogerZhang888 wants to merge 21 commits intosource-academy:masterfrom
Conversation
…re where clicked arrows remain highlighted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Overview
Arrows now have a buffer of 30px.
This ensures that the arrow will extend in a straight line for at least 30px before bending.
Major Changes
CSEMachineConfig.ts: added a constantMinTerminalSegmentLength(currently set to 30, this can be adjusted).ArrowFromText.ts: calculation of arrow's path takes into accountMinTerminalSegmentLength.Type of change
How to test
Checklist