Open
Conversation
Collaborator
Author
|
Note that this requires the user setting debug.allowBreakpointsEverywhere. Since this is a user setting, it cannot be set by the extension, so we should tell the user to do this |
Collaborator
Author
|
Nevermind I was mistaken, extensions can set user settings |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request detects when a breakpoint is added, removed, or changed (either moved to a new line, or the line being deleted entirely), and sends a message to the frontend to update the breakpoints.
Currently it only works on the current active editor, and when a new editor is opened, it replaces all the breakpoints in that file with the breakpoints stored on Source Academy. I hope contributors can chip in whether this behaviour is what we should keep, or if we should implement a way to sync breakpoints even when they are added to non active editors.
This implementation requires the vscode/breakpoints branch on the frontend, I have tested that it works as expected on the playground. @heyzec could you help me test if it works on assessments as well? I believe it should as the code to handle the new breakpoint message is on Application.tsx so it should apply to both playground and assessment.