feat(object-browser): show last modified time for files - #470
Draft
alukach wants to merge 1 commit into
Draft
Conversation
Files in the directory listing now show their last modified time as a
relative value ("3 weeks ago"), left of the download/copy/delete buttons,
with the exact UTC timestamp in a tooltip and the title attribute.
Directories are skipped: object stores have no prefix mtime, so the
listing synthesizes "now" for them.
Closes #469
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #469 (partially — object listing only).
Files in the directory listing now show when they were last modified, between the file size and the download/copy/delete buttons.
Intl.RelativeTimeFormat— no new dependency.titleattribute, so it is reachable without a hover.nowfor them, which would be misleading.suppressHydrationWarningon the text: "now" differs between the server and client render, so a just-uploaded file can disagree by a few seconds.MonoTextbecameforwardRefso Radix'sTooltipcan anchor to it.Verification
src/lib/format.test.ts— unit tests forformatRelativeTime(seconds → years, unparseable input).src/components/features/products/object-browser/DirectoryRow.test.tsx— asserts the relative text renders with a UTCtitle, and that directories don't get one.npm run lintandnpm run type-checkclean for the touched files (the pre-existingrechartsmodule-not-found errors are unrelated, that dependency isn't installed in this environment).Not included
The issue also asks for a last-modified indicator at the repo/product level. That needs a product-level aggregate that isn't computed today, so it is left out here.
🤖 Generated with Claude Code