fix(web): reuse CodeMirror search language - #1580
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughThe change initializes Zoekt CodeMirror language support once at module load time. The ChangesZoekt language support reuse
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StreamLanguageandLanguageSupportonce per modulezoekt()API while returning the shared instanceRoot cause
Every server render of the browse SearchBar called
StreamLanguage.define(). CodeMirror permanently registers each language documentNodeTypein a module-global array, retaining the per-render language and closures after GC. The singleton prevents one permanently rooted language instance from being created per browse request.Linear: SOU-1978
Validation
yarn workspace @sourcebot/web test --run "src/app/(app)/components/searchBar/zoektLanguageExtension.test.ts"git diff --checkThe repository-wide web TypeScript check currently reports unrelated pre-existing errors in review-agent, MCP Prisma-scope, file-source, and auth test fixtures; neither changed file reports an error.
Note
Cursor Bugbot is generating a summary for commit 2a019d5. Configure here.
Summary by CodeRabbit