chore/ci: remove broken SCIP upload workflow - #100
Open
keegancsmith wants to merge 1 commit into
Open
Conversation
Sourcegraph no longer accepts the workflow's GitHub token as upload authentication, so every push reports a failure after indexing succeeds. Keeping this upload would require a separately managed Sourcegraph access token; this repository does not otherwise need that credential, and comparable OSS repositories such as zoekt do not publish SCIP indexes from CI. Remove the obsolete workflow rather than leaving a permanently failing check or masking upload errors. Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-019fb780-ec22-75e7-91a7-34c027582456
keegancsmith
marked this pull request as ready for review
July 31, 2026 09:34
Member
Author
|
@emidoots @chrapkowski-sg not sure if we should remove or fix? If fix, we should make it work for zoekt as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SCIP workflow currently generates its index successfully but every upload fails with
no current user. The built-in GitHub token is still being passed, but Sourcegraph now requires a Sourcegraph access token for this upload path. This leaves unrelated changes, including #99, with a failing check on every push.Repositories that still publish SCIP data, such as
sourcegraph/log, use an organization-managed Sourcegraph token and target the internal Sourcegraph instance. This repository has no such repository secret, while the comparable OSS Go repositorysourcegraph/zoekthas no SCIP upload workflow at all. Remove the workflow rather than adding credential ownership and rotation for this small library or hiding failures withignore-upload-failure.This does not affect the Go test workflow; it only stops the unauthenticated external index upload.