Skip to content

Conversation

@jviotti
Copy link
Member

@jviotti jviotti commented Jan 16, 2026

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

@augmentcode
Copy link

augmentcode bot commented Jan 16, 2026

🤖 Augment PR Summary

Summary: This PR switches generator validation to rely solely on the TypeScript end-to-end (E2E) test suite.

Changes:

  • Removed the C++ generator unit test target (test/generator) from the test build.
  • Deleted the large generator_typescript_test.cc suite that asserted generator output via IR construction.
  • Added new TypeScript E2E fixtures for Draft 2020-12 covering complex enum values, recursive $ref schemas, and special JSON property names.
  • Each new fixture includes schema.json, options.json, an expected.d.ts golden file, and a test.ts type-check program.

Technical Notes: The E2E harness compares generated output against expected.d.ts and runs tsc --strict --noEmit over the fixture to ensure the generated declarations are usable by TypeScript.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@jviotti jviotti merged commit 0de5bb7 into main Jan 16, 2026
12 checks passed
@jviotti jviotti deleted the e2e-tests branch January 16, 2026 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants