Skip to content

Conversation

@jviotti
Copy link
Member

@jviotti jviotti commented Jan 16, 2026

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@augmentcode
Copy link

augmentcode bot commented Jan 16, 2026

🤖 Augment PR Summary

Summary: This PR improves how generated symbols are derived when schema locations include bundled (absolute-URI) identifiers.

Changes:

  • Introduced URI-aware token handling in src/ir/ir_symbol.cc to split absolute URIs into path segments when building symbol names.
  • Kept non-URI tokens unchanged, falling back gracefully when parsing fails.
  • Updated TypeScript E2E bundled-schema fixtures to expect shorter, path-based names (e.g. SchemasUser) instead of host+scheme concatenations.

Technical Notes: Absolute URIs are parsed via sourcemeta::core::URI, and only non-empty path segments are used when constructing the final reversed symbol vector.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@jviotti jviotti merged commit 299f2a3 into main Jan 16, 2026
12 checks passed
@jviotti jviotti deleted the better-bundled branch January 16, 2026 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants