Skip to content

Conversation

@jviotti
Copy link
Member

@jviotti jviotti commented Jan 16, 2026

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@jviotti jviotti merged commit 1136d92 into main Jan 16, 2026
12 checks passed
@jviotti jviotti deleted the file-uris-extensions branch January 16, 2026 19:40
@augmentcode
Copy link

augmentcode bot commented Jan 16, 2026

🤖 Augment PR Summary

Summary: This PR improves how symbol/name segments are derived from embedded resource identifiers in $defs, especially when those identifiers are URIs that include file extensions.

Changes:

  • Added a helper to strip all filename extensions (e.g., email.schema.jsonemail) when deriving symbol segments.
  • Adjusted URI token parsing so the last path segment has its extensions removed.
  • Special-cased file:// URIs to use only the filename (without extensions) when generating symbol segments.
  • Updated the bundled-schema TypeScript e2e fixture to use .json / multi-extension URIs in $ref, $id, and $defs keys.
  • Added a new TypeScript e2e fixture covering bundled schemas that use file:// URIs.

Technical Notes: The updated logic preserves existing path-segment behavior for non-file absolute URIs while improving stability/readability of generated identifiers when schemas are named with common JSON Schema filename conventions.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants