Skip to content

Conversation

@jviotti
Copy link
Member

@jviotti jviotti commented Jan 16, 2026

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@augmentcode
Copy link

augmentcode bot commented Jan 16, 2026

🤖 Augment PR Summary

Summary: This PR improves TypeScript string escaping so generated code can safely represent JSON Schema property names containing ASCII control characters.

Changes:

  • Added explicit escaping for backspace (\b) and form feed (\f) in the TypeScript generator.
  • Escapes remaining control characters below 0x20 using \uXXXX sequences.
  • Added an end-to-end TypeScript test fixture covering control characters in property names (including NUL, SOH, and US).

Technical Notes: Uses <iomanip> stream formatting (std::hex/std::setw/std::setfill) to produce zero-padded 4-digit Unicode escapes.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@jviotti jviotti merged commit 10466c0 into main Jan 16, 2026
12 checks passed
@jviotti jviotti deleted the escape-tests branch January 16, 2026 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants