Respect ordering of --resolve arguments to avoid meta-schema ambiguity#674
Merged
Respect ordering of --resolve arguments to avoid meta-schema ambiguity#674
--resolve arguments to avoid meta-schema ambiguity#674Conversation
73fd877 to
339cfb4
Compare
🤖 Augment PR SummarySummary: This PR fixes ambiguous custom meta-schema resolution by preserving the user-provided ordering of repeated Changes:
Technical Notes: The new behavior maintains stable inter-argument ordering while still sorting any multi-file expansions (e.g., directories) per argument to keep output deterministic. 🤖 Was this summary useful? React with 👍 or 👎 |
There was a problem hiding this comment.
1 issue found across 3 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="test/validate/fail_resolve_custom_metaschema_ordering.sh">
<violation number="1" location="test/validate/fail_resolve_custom_metaschema_ordering.sh:52">
P3: The test name indicates a failure case, but the expected output asserts a successful validation. Rename the test to a `pass_*` name (and update the CMake registration) or change the expected output to reflect an actual failure so the test name matches its behavior.
(Based on your team's feedback about naming methods and tests to reflect behavior.) [FEEDBACK_USED]</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
See: #672 Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
339cfb4 to
5febc96
Compare
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Feb 24, 2026
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [sourcemeta/jsonschema](https://github.com/sourcemeta/jsonschema) | patch | `v14.13.3` → `v14.13.4` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>sourcemeta/jsonschema (sourcemeta/jsonschema)</summary> ### [`v14.13.4`](https://github.com/sourcemeta/jsonschema/releases/tag/v14.13.4) [Compare Source](sourcemeta/jsonschema@v14.13.3...v14.13.4) #### What's Changed - Fix bundling not de-duplicating equal schemas by [@​jviotti](https://github.com/jviotti) in [#​669](sourcemeta/jsonschema#669) - Improve error handling on `--resolve` meta-schema errors by [@​jviotti](https://github.com/jviotti) in [#​673](sourcemeta/jsonschema#673) - Respect ordering of `--resolve` arguments to avoid meta-schema ambiguity by [@​jviotti](https://github.com/jviotti) in [#​674](sourcemeta/jsonschema#674) **Full Changelog**: <sourcemeta/jsonschema@v14.13.3...v14.13.4> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4zMS4xIiwidXBkYXRlZEluVmVyIjoiNDMuMzEuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90IiwiYXV0b21hdGlvbjpib3QtYXV0aG9yZWQiLCJkZXBlbmRlbmN5LXR5cGU6OnBhdGNoIl19-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: #672
Signed-off-by: Juan Cruz Viotti jv@jviotti.com