Conversation
6c201b8 to
f74ed28
Compare
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
f74ed28 to
f744137
Compare
There was a problem hiding this comment.
1 issue found across 9 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="enterprise/scripts/sbom.js">
<violation number="1" location="enterprise/scripts/sbom.js:23">
P1: Avoid interpolating the untrusted `image` argument into shell commands executed via execSync; this enables command injection. Use execFile/execFileSync with an арг array to avoid shell parsing, or validate/sanitize `image` before use.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| execSync(`docker pull ${image}`, { stdio: [ "ignore", "inherit", "inherit" ] }); | ||
| } | ||
|
|
||
| const container = execSync(`docker create ${image}`, { encoding: "utf-8" }).trim(); |
There was a problem hiding this comment.
P1: Avoid interpolating the untrusted image argument into shell commands executed via execSync; this enables command injection. Use execFile/execFileSync with an арг array to avoid shell parsing, or validate/sanitize image before use.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At enterprise/scripts/sbom.js, line 23:
<comment>Avoid interpolating the untrusted `image` argument into shell commands executed via execSync; this enables command injection. Use execFile/execFileSync with an арг array to avoid shell parsing, or validate/sanitize `image` before use.</comment>
<file context>
@@ -0,0 +1,114 @@
+ execSync(`docker pull ${image}`, { stdio: [ "ignore", "inherit", "inherit" ] });
+ }
+
+ const container = execSync(`docker create ${image}`, { encoding: "utf-8" }).trim();
+ execSync(`docker cp ${container}:/usr/share/sourcemeta/one/npm-packages.spdx.json ${workdir}/npm.json`);
+ execSync(`docker cp ${container}:/usr/share/sourcemeta/one/vendor-packages.spdx.json ${workdir}/vendor.json`);
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juan Cruz Viotti jv@jviotti.com