Skip to content

Better resist invalid route ids in the server#663

Merged
jviotti merged 1 commit intomainfrom
server-handle-unsafe-route
Feb 24, 2026
Merged

Better resist invalid route ids in the server#663
jviotti merged 1 commit intomainfrom
server-handle-unsafe-route

Conversation

@jviotti
Copy link
Member

@jviotti jviotti commented Feb 24, 2026

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@augmentcode
Copy link

augmentcode bot commented Feb 24, 2026

🤖 Augment PR Summary

Summary: Adds a bounds check before dispatching into the HANDLERS table so invalid/unknown route handler identifiers don’t crash the server.
Why: Improves backward compatibility when a generated routes.bin doesn’t match this server build by returning a 501 JSON error instead of indexing out of range.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@jviotti jviotti merged commit 2788a22 into main Feb 24, 2026
6 checks passed
@jviotti jviotti deleted the server-handle-unsafe-route branch February 24, 2026 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant