Increase server robustness on invalid underlying data

[jviotti]

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

[augmentcode]

🤖 Augment PR Summary

Summary: Makes server actions fail with runtime errors (instead of debug-only asserts) when metapack/schema inputs are missing or malformed.

Key changes:

• JSON Schema evaluate/trace: replace several precondition checks with std::runtime_error.
• Schema search: throw on missing/unreadable search index rather than asserting.
• Metapack reader: validate required metadata fields/types and throw on unknown encodings.

_{🤖 Was this summary useful? React with 👍 or 👎}

[augmentcode]

Review completed. 3 suggestions posted.

Comment augment review to trigger a new review at any time.

[augmentcode]

sourcemeta::core::JSON::defines() asserts is_object(), so if locations isn’t an object this can still assert/UB (especially in release builds where assert is compiled out). If the goal is robustness on invalid data, consider guarding locations.is_object() (or using try_at) before calling defines/at.

Severity: high

_{🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.}

[augmentcode]

This has_value() check won’t help if malformed current_location causes current_location.at("baseDialect") (and later at("dialect")) to assert/UB before to_base_dialect() is called. If these fields can be missing/invalid, consider validating presence/type without at() first.

Severity: high

Other Locations

• src/server/action_jsonschema_evaluate.h:103

_{🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.}

[augmentcode]

If this PR’s intent is to avoid debug-only enforcement, note the remaining assert(search_index.is_absolute()) below will be a no-op in release builds (potentially allowing unexpected relative paths). Consider making that invariant a runtime check too.

Severity: medium

_{🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.}

[cubic-dev-ai]

2 issues found across 3 files

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="src/server/action_schema_search.h">

<violation number="1" location="src/server/action_schema_search.h:25">
P2: The new runtime_error thrown here is uncaught in action_schema_search, so it falls back to dispatch’s generic handler and returns HTTP 405 "method-not-allowed" for missing/failed search indexes. That status is misleading for an internal/index error; handle the error locally and return an appropriate 404/500 response instead.</violation>
</file>

<file name="src/server/action_jsonschema_evaluate.h">

<violation number="1" location="src/server/action_jsonschema_evaluate.h:36">
P1: `JSON::defines()` internally asserts `is_object()`, so if the parsed `locations` value is not a JSON object (e.g., malformed file), this will still assert/UB before the `defines("static")` check can throw. Add a `locations.is_object()` guard before calling `defines()` to fully cover the robustness goal.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}