Skip to content

Comments

Upgrade Core to 84c6f450b2998a6558aef4174039a0fa427d9b5b#670

Merged
jviotti merged 1 commit intomainfrom
core-new-router
Feb 24, 2026
Merged

Upgrade Core to 84c6f450b2998a6558aef4174039a0fa427d9b5b#670
jviotti merged 1 commit intomainfrom
core-new-router

Conversation

@jviotti
Copy link
Member

@jviotti jviotti commented Feb 24, 2026

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

@augmentcode
Copy link

augmentcode bot commented Feb 24, 2026

🤖 Augment PR Summary

Summary: Updates the vendored sourcemeta/core dependency to commit 5d5098c….

Changes:

  • Bumps the Core SHA in DEPENDENCIES to pull in upstream updates.
  • Refactors URITemplateRouterView to load the serialized router into an in-memory byte buffer instead of relying on a memory-mapped FileView.
  • Adds URITemplateRouterReadError to represent failures when opening/reading a router file.
  • Removes the uritemplate CMake link dependency on sourcemeta::core::io, aligning build deps with the new implementation.

Technical Notes: Router matching now operates on a std::vector<std::uint8_t> backing store, so file I/O and bounds validation become the key correctness considerations.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 2 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

@jviotti jviotti changed the title Upgrade Core to 5d5098cc7c7537f4ff3da9848233ea314faffb2f Upgrade Core to 84c6f450b2998a6558aef4174039a0fa427d9b5b Feb 24, 2026
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@jviotti jviotti merged commit f699936 into main Feb 24, 2026
5 checks passed
@jviotti jviotti deleted the core-new-router branch February 24, 2026 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant