Fix separator handling in rendered values - #55
Merged
manuelwedler merged 3 commits intoJul 29, 2026
Conversation
manuelwedler
requested changes
Jul 16, 2026
manuelwedler
left a comment
Member
There was a problem hiding this comment.
This completely removes the use of separator and not displays the separator anymore. I see the point that it might not be best to put it in value, but where do you think should the separator go else?
From ERC-7730:
Each element of the array is formatted using the provided formatter, and the separator value is displayed before each element.
Contributor
Author
|
My understanding is that {
label: "Tip amount",
value: "1 USDC",
separator: "Tip 0"
}This would let wallets display the computed separator before each array element, while keeping If you'd like, I'd be happy to update this PR accordingly, or add it as a separate PR. |
manuelwedler
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
separatortext out of rendered field valuesseparatortext out ofinterpolatedIntentsubstitutionsContext
This was surfaced while testing the Ocarina ERC-7730 registry submission: ethereum/clear-signing-erc7730-registry#2598.
That descriptor uses array item separators such as:
The separator is useful presentation context for array items, but it should not become part of the rendered field value itself. Before this change, Sourcify could render an interpolated intent like:
instead of:
Details
DisplayField.valuenow contains only the formatted field value, and therenderedValuesinterpolation map stores the same clean value.This keeps separator handling out of semantic values while preserving the descriptor’s field formatting behavior. If wallets want to expose separator text as presentation metadata, that can be added separately without contaminating
value.Validation
npm testnpm run check:typesnpm run check:eslintnpm run check:prettier