Run test subprocesses outside the parent Bundler env#2225
Merged
Conversation
Under Bundler 4, `require "bundler/setup"` exports `BUNDLE_LOCKFILE` into ENV (a new behaviour since 2/3 -- see `set_bundle_variables`), so `ShellHelper#sh!` leaks it into child processes. The binstub tests then run `bundle install` in a tmpdir whose Gemfile uses `gem "steep", path: ...`, and the inherited `BUNDLE_LOCKFILE` causes that install to rewrite this project's `Gemfile.lock` -- dropping the optional `development` group and breaking subsequent `bundle exec`s with `Could not find gem 'stackprof mri'`. Wrap the `Open3` calls in `Bundler.with_unbundled_env` so each child starts with a clean Bundler env.
soutaro
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under Bundler 4,
require "bundler/setup"exportsBUNDLE_LOCKFILEinto ENV (a new behaviour since 2/3 -- seeset_bundle_variables), soShellHelper#sh!leaks it into child processes. The binstub tests then runbundle installin a tmpdir whose Gemfile usesgem "steep", path: ..., and the inheritedBUNDLE_LOCKFILEcauses that install to rewrite this project'sGemfile.lock-- dropping the optionaldevelopmentgroup and breaking subsequentbundle execs withCould not find gem 'stackprof mri'.Wrap the
Open3calls inBundler.with_unbundled_envso each child starts with a clean Bundler env.