Include inline source files in --save-expectations#2234
Open
ksss wants to merge 2 commits into
Open
Conversation
When a target is configured with `inline: true`, the inline source files were not collected into `all_files`, so `--save-expectations` produced an empty YAML even when diagnostics were reported. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a target is configured with
inline: true,steep check --save-expectationsproduced an empty YAML (--- []) even when diagnostics were reported, because the inline source files were not collected intoall_files.print_typecheck_resultwas iterating overtarget.source_patternandtarget.signature_patternonly, missingtarget.inline_source_pattern. This change adds the missing iteration so inline source files participate in both the populate and prune logic ofsave_expectations.Repro
With this fix,
steep_expectations.ymlcorrectly contains thelib/foo.rbentry with its diagnostics.Test plan
bundle exec ruby -Itest test/cli_test.rb -n test_check_inline_save_expectations🤖 Generated with Claude Code