Allow single Object fields to accept any type in acceptChange#19
Merged
sovdeeth merged 2 commits intosovdeeth:mainfrom Aug 27, 2025
Merged
Allow single Object fields to accept any type in acceptChange#19sovdeeth merged 2 commits intosovdeeth:mainfrom
sovdeeth merged 2 commits intosovdeeth:mainfrom
Conversation
sovdeeth
requested changes
Aug 25, 2025
Comment on lines
180
to
184
| // if a field is single and object, it should allow object stuff | ||
| if (isAnyFieldSingle && returnType == Object.class) { | ||
| return new Class<?>[]{Object.class}; | ||
| } | ||
|
|
Owner
There was a problem hiding this comment.
i'd move this under the existing isAnyFieldSingle check but otherwise seems fine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures that single
Objectfields inExprFieldAccess#acceptChangeare always accepted asObject.class.Fixes #18