cellAudio: clear each consumed ring buffer block - #83
Open
canersaka wants to merge 1 commit into
Open
Conversation
Zero a port block after mixing it and before publishing the next read index. This matches the AudioServer contract, prevents a stalled producer from replaying stale PCM, and preserves the cleared-block consumption signal used by producers.
canersaka
marked this pull request as ready for review
July 25, 2026 05:56
sp00nznet
added a commit
that referenced
this pull request
Aug 15, 2026
tsautier
pushed a commit
to tsautier/ps3recomp
that referenced
this pull request
Aug 15, 2026
… ABI/lv2 batch) CONTRIBUTORS.md gains canersaka's six-PR batch (sp00nznet#83-sp00nznet#88); README gets an Unreleased changelog section covering everything folded via integrate/fold-2026-08-14, attributed per fix. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The audio consumer advanced the read index after mixing a block but left the consumed samples in guest memory. A producer that does not completely overwrite that slot before it wraps around can therefore replay stale PCM from the previous trip through the ring. RPCS3's cellAudio consumer clears the block before advancing the read position for the same reason.
This zeros exactly the consumed block after it has been copied into the host mix buffer and before the read index is published. The producer-visible read-index behavior and the existing sample conversion stay unchanged.
Verified: ps3recomp_runtime builds clean from the current ps3recomp staging base with this as the only changed file. I also traced the consume order against RPCS3's reset_ports(0) path; the clear is on the consumed slot before the read position advances, not on the producer's next slot.