Draft
Conversation
PJB3005
reviewed
Jul 15, 2025
Member
PJB3005
left a comment
PJB3005
left a comment
There was a problem hiding this comment.
you have have made the mistake of opening the first PR or issue on this repo I am automatically watching.
| var dbFileFound = await _dbContext.ConvertedFile.AnyAsync(x => x.RelativePath == Path.GetFileName(file)); | ||
| if (dbFileFound) | ||
| continue; | ||
| if(Directory.Exists(Path.Combine(_serverConfiguration.UserContentDirectory, ConvertedDirectory))) { |
Member
There was a problem hiding this comment.
Don't copy paste this Path.Combine(_serverConfiguration.UserContentDirectory, ConvertedDirectory)
Contributor
There was a problem hiding this comment.
This if statement can be removed as the issue why it was necessary in the first place got fixed on master
|
Overall happy to see this done, containerized web development is essential. I really need to actually do some explo of this project now I can actually spool it up and poke at it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #7