chore(deps-dev): upgrade electron from 24.3.1 to 35.7.5#64
Merged
Conversation
- Update electron to ^35.7.5 in root package and playground example - Fix TypeScript compatibility: use Electron's IpcRendererEvent type instead of custom interface (removes senderId requirement) - Simplify removeListener call by removing unnecessary cast - Add skipLibCheck to playground tsconfig to resolve @types/node conflicts with Electron's bundled types Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR upgrades Electron from version 24.3.1 to 35.7.5, a major version jump spanning 11 major releases. The upgrade requires TypeScript compatibility fixes to address breaking changes in Electron's type definitions, particularly around IPC event handling.
Changes:
- Upgrade Electron dependency from ^24.3.1 to ^35.7.5 in both main package and playground example
- Replace custom IpcRendererEvent interface with Electron's native type
- Simplify removeListener implementation to use a cleaner type cast instead of casting the entire ipcRenderer object
- Add skipLibCheck to playground tsconfig.json to resolve type conflicts between @types/node and Electron's bundled types
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updates Electron dev dependency to ^35.7.5 |
| src/ProgressWindow/preload.ts | Adopts Electron's native IpcRendererEvent type and simplifies removeListener with cleaner type casting |
| examples/playground/package.json | Updates Electron dev dependency to match main package version |
| examples/playground/tsconfig.json | Adds skipLibCheck to handle type conflicts in example code |
| examples/playground/package-lock.json | Updates dependency tree for Electron 35.7.5, including @types/node upgrade to v22 and lockfile format v3 |
Files not reviewed (1)
- examples/playground/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
IpcRendererEventtype instead of custom interfaceremoveListenercall by removing unnecessary castsskipLibCheck: trueto resolve type conflicts between@types/nodeand Electron's bundled typesWhy these changes were needed
The Electron 35 types changed the
IpcRendererEventinterface. The previous custom interface required asenderIdproperty that doesn't exist on the renderer-side event. Using Electron's own exported type ensures forward compatibility.Test plan
npm run build)npm test)npm run test:e2e) - CI will verify🤖 Generated with Claude Code