perf: persistent CM editor#239
Merged
Merged
Conversation
programmatic content swaps via recycleSourceView() fire docChanged but should not mark the file dirty or schedule persistence. add a isSwappingContentRef flag around setState() calls and check it in the update listener. also fix flushPendingWork() to only flush when work is actually scheduled, preventing stale state persistence during effect cleanup. other changes: - add theme-matched background color to source mode editor container - exclude all benchmark tests from e2e suite (not just memory) - flatten loader match() nesting with early isLeft returns - guard callbacks on editorId/fileId availability Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
search, external search highlighting, and diff gutter visuals are loaded via requestIdleCallback instead of blocking the initial EditorState build. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
replace key-based remounting with imperative content swap in Editor, fixing cleanup ordering so pending state flushes to the OLD file. source editor cleanup now uses closure-captured filePath/editorId instead of refs that already point to the NEW file during cleanup. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.