Conversation
Contributor
|
I suggest we keep this on a branch to be included in the STTC release, and request permission from CSP to use csp_get_buffer_always from L2 interfaces not defined internally in libcsp |
|
Yes. Buffer get always was designed for exactly this. If the uplink CBLK interface cannot allocate a CSP buffer, its best to flush everything by rebooting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
safety check for buffer allocation failures in the
csp_if_cblk_rxfunction.Error handling improvements:
csp_buffer_getto ensure that a valid buffer was allocated. If allocation fails, the code now callscsp_panicand enters an infinite loop to prevent undefined behavior.csp_buffer_get_always is in private header