Feature/enable-standard-install#32
Closed
jeanbaptistelab wants to merge 26 commits into
Closed
Conversation
Although I dont know how exactly csp_connect() leaves fields on csp_id_t unitialized, but Valgrind certainly seems to think that they are.
Previously, posix instances using CAN did not accept L2 and L3 broadcast due to HW filtering
The issue originates in the fact that L3 data is overriding L2 data in the csp_packet header. This is resolved on the libcsp/libcsp/develop branch already, by removing the union.
…y_clone_bytes Remove unnecessary clone of a few bytes in csp_buffer_clone
check timeout and close connection if timed out even if user space has it
Commit inspired by @moonlight83340 libcsp#834
Commit inspired by @moonlight83340 libcsp#856
We should consider actually returning an error. Instead we still just override the last available route, which seems to have been the previous intention. Co-authored-by: edvard <edvard@space-inventor.com>
When it isn't exactly 40 characters long
Added `csp_zmqhub_<add/remove>_filters()` to change promisc settings after init
This is used for multicast-like operations, similar to the original concept of CAN
jeanbaptistelab
force-pushed
the
feature/enable-standard-install
branch
from
99d000b to
2fa48a1
Compare
Currently, installing CSP through meson does not allow other modules to use the installed version as it does not generate the required pkg-config files.
jeanbaptistelab
force-pushed
the
feature/enable-standard-install
branch
from
2fa48a1 to
289cbcd
Compare
"runtime" will install the shared library only, "devel" will install the static library, headers and pkg-config files
|
I suppose that is fine... |
|
With this branch I can successfully build libparam as a shared object, with Meson finding the installed libcsp dependency. But it does point to our (perhaps incorrect) usage of So the following is not allowed: |
|
Closing here, as its open upstream now too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, installing CSP through meson does not allow other modules to use the installed version as it does not generate the required pkg-config files, this PR addresses this