Conversation
johandc
requested changes
May 1, 2026
| extern void vApplicationStackOverflowHook(TaskHandle_t pxTask, char *pcTaskName); | ||
| extern void vApplicationMallocFailedHook(void); | ||
| extern void vApplicationIdleHook(void); | ||
| extern void vApplicationTickHook( void ) __attribute__((weak)); |
Contributor
There was a problem hiding this comment.
This should not be weak, FreeRTOS is going to call it, if its enabled, and there is no runtime check for the existence. So the application could be built without an implementation. At least provide a weak deafault implementation if you do.
Author
There was a problem hiding this comment.
There is already an implementation of vApplicationTickHook in this file, and need to declare it weak else the linker will complain of multiple definition of `vApplicationTickHook'
Contributor
There was a problem hiding this comment.
Okay, then remove the extern from the declaration, and put the attribute weak on the implementation further down
…f the function in c21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.