Merged
Conversation
scheibelp
approved these changes
Feb 5, 2026
Member
scheibelp
left a comment
scheibelp
left a comment
There was a problem hiding this comment.
This looks reasonable (and thanks for the test), although if you could update the PR description I'd appreciate it, e.g.
Corrects an issue where the error pipes were not copied on assign or copy or included in the process start info or closed.
I'm having trouble parsing this
(other comment here is also related to the PR description)
All that said, I made some requests on #24, so this may need updates after that is changed.
Ensures child stderr pipes are handled gracefully Corrects an issue where the error pipes were not copied on assign or copy or included in the process start info or closed. Signed-off-by: John Parent <john.parent@kitware.com>
johnwparent
force-pushed
the
pipe-error-out
branch
from
21e925f to
e62cb4b
Compare
scheibelp
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stderr: overhaul error piping from child
Ensures child stderr pipes are handled at all and appropriately.
Corrects an issue where the error pipes were not copied on assign or copy or included in the process start info or closed.
Based on #24