docs: Add menu drawer toggle to header on smaller viewports#105
docs: Add menu drawer toggle to header on smaller viewports#105joestrouth1 wants to merge 5 commits intosparkjsdev:mainfrom
Conversation
|
Oh wow. this is awesome. It looks good. Gonna give it a try tomorrow before merge. Thanks so much for the effort |
|
iphone SE is as small as phones can be these days and you have space from screenshot above. reduce left margin / padding of the magnifiying lense and use a "menu icon" instead of menu word |
|
Most recent changes:
iPhone SE:iPhone 14 Pro Max:iPad Mini:iPad Pro / laptop class: |
|
Thanks so much. Icons should be probably spread more evenly and centered in the header in mobile screens. Also can we put the spark logo on the mobile menu vs the default one? |
|
I think it looks a bit odd with the Search icon before the Menu icon. I think it would look better with the Search icon positioned after all menu items and before the Discord icon. This is then also in line with how other websites are structured. Plus, the most used items should be on the left and lesser used further right. Menu is more important than the Search. |





See #87
Adds a 'Menu' button the the site header which opens the navigation drawer when clicked.
>=1220px wide (unchanged):
Tablet:
It needs work on phones. The header is already too wide for small (iPhone SE) screens and adding a menu/drawer toggle worsens the problem.
Some options for shrinking the width of header contents: