fix: forward fileType to SplatLoader in PackedSplats.asyncInitialize#283
Open
zzha9494 wants to merge 1 commit intosparkjsdev:mainfrom
Open
fix: forward fileType to SplatLoader in PackedSplats.asyncInitialize#283zzha9494 wants to merge 1 commit intosparkjsdev:mainfrom
zzha9494 wants to merge 1 commit intosparkjsdev:mainfrom
Conversation
When using a URL without a recognizable file extension (e.g. blob URLs), the fileType option passed to SplatMesh/PackedSplats was not forwarded to the internal SplatLoader instance, causing 'Unknown splat file type' error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #233
Bug: When constructing a SplatMesh with url + fileType, the fileType is never forwarded to the internal SplatLoader instance created in PackedSplats.asyncInitialize(). This causes URLs without recognizable extensions (e.g. Blob URLs) to fail with Unknown splat file type: undefined.
Fix: Add loader.fileType = options.fileType before calling loader.loadAsync(url).