Open
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17 +/- ##
==========================================
- Coverage 94.44% 94.43% -0.01%
==========================================
Files 15 15
Lines 1782 1779 -3
==========================================
- Hits 1683 1680 -3
Misses 99 99
Continue to review full report at Codecov.
|
Contributor
|
Thanks for the PR! As for your other issue, I'm not sure if that is the best fix, but let's start another PR with a test and your fix and I'll try it out. |
Contributor
|
@shawwn ping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I haven't been able to reproduce the problem described in these comments:
This PR removes this transformation step.
I did run into a similar problem where
arith.constant 0 : indexwas being parsed asarith.constant0. The root issue was inbare_id. I solved it by inlining the regexes, and introducingplain_id:... and then replacing each instance of
bare_id "." bare_idwithplain_id "." plain_id. I can submit that as a PR if you'd like.