mkalias update version 0.6 if/when destination is an already existin…#9
mkalias update version 0.6 if/when destination is an already existin…#9hereisderek wants to merge 6 commits into
Conversation
… folder, new alias will be created inside of given folder
specious
left a comment
specious
left a comment
There was a problem hiding this comment.
Thank you for this contribution. Please take a look at my comments.
|
|
||
|
|
||
| 0.6 | ||
| * if/when destination is an already existing folder, new alias will be created inside of given folder by Derek(https://github.com/1and1get2 ) |
There was a problem hiding this comment.
I appreciate the attribution contribution, but proper formatting would be nice.
| } | ||
|
|
||
| //check if the destination is an existing folder, if so create alias inside of destination folder | ||
| char newDest[strlen(destPath) + strlen(filename) + 10]; |
There was a problem hiding this comment.
What is the reasoning behind the 10 literal?
There was a problem hiding this comment.
I really don't remember.. probably just messing around and forgot to revert the changes.
I haven't done any c/c++ for a long time needed to try things out
|
i removed the "10 literal" thingy, however, I'm not certain what to do with the format, it looks okay I think? |
specious
left a comment
specious
left a comment
There was a problem hiding this comment.
Thank you for your additions. Please take another look :)
| /* | ||
| CHANGES | ||
|
|
||
|
|
There was a problem hiding this comment.
Spurious spaces. I see them in my editor :)
| strcat(newDest, "/"); | ||
| strcat(newDest, (char *)filename); | ||
| destPath = newDest; | ||
| // printf("Destination is an existing folder, changing to new location: %s\n", (char *) destPath); |
There was a problem hiding this comment.
What value does this commented out log statement add?
There was a problem hiding this comment.
not much probably. it should get stripped out when being compiled
2 participants
…g folder, new alias will be created inside of given folder