Update the BCC lab to bring the html report front and center#50
Merged
Conversation
The backward-compatibility-check output now pins each breaking change to its exact file, line, and column. Update the expected output and add a short note guiding the learner to use it.
Add an 'Open the HTML report' step to Part B that opens the generated report from the labs repo root, with landing-page and breaking-change screenshots so learners know what to expect.
Restructure Part B so the HTML report comes first: point readers to the report file, walk through the breaking-change card (rule, severity, breadcrumb, and file:line:column source), and move the console output to the end. Drop the browser opener commands in favour of the report path.
Consolidate the fix and re-run into Part C, mirroring Part B: edit the spec, re-run, then lead with the HTML report showing the operation is now compatible, with the console verdict last. Removes the redundant Part D.
sahilm
force-pushed
the
sahilm/bcc-reports-update-bcc-labs
branch
from
5b8861b to
95e9bf8
Compare
sahilm
changed the title
Add docker sed shortcuts for the Part A breaking change and Part C fix, switch the Windows variants to powershell blocks (parsed but not executed) placed after their command output, and drop the fictional git-restore output line.
# Conflicts: # backward-compatibility-testing/README.md
Contributor
|
I've made all the changes, once we cut the release we can merge this. Till then it would be failing, so don't want to merge yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the BCC lab to bring the html report front and center. Highlights the error grouping and line number breadcrumbs.