Footer - #444
Open
lauracastrovenegas wants to merge 19 commits into
Open
Conversation
CarolineHoang
previously approved these changes
May 22, 2020
CarolineHoang
left a comment
CarolineHoang
left a comment
Contributor
There was a problem hiding this comment.
Footer functions perfectly on test
Discovered that the whole page is not centered flush in the mobile view, but this is not an issue with the footer.
CarolineHoang
dismissed
their stale review
May 24, 2020 15:29
I've realized that there are sizing issues in this code on mobile. I am fixing them now.
CarolineHoang
left a comment
CarolineHoang
left a comment
Contributor
There was a problem hiding this comment.
I have fixed the mobile compatibility issues. This should be good to go.
CarolineHoang
approved these changes
May 24, 2020
CarolineHoang
left a comment
CarolineHoang
left a comment
Contributor
There was a problem hiding this comment.
I have fixed the mobile compatibility issues. This should be good to go.
Contributor
|
Looks good, only thing is deciding how/when to update credits |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finished footer for website