-
Notifications
You must be signed in to change notification settings - Fork 0
Feature kpoland public datasets view #245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2c69a33 to
9bee670
Compare
9bee670 to
b233070
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds a public datasets search feature, allowing users to discover and search published datasets without authentication. The implementation includes new view classes for searching published datasets, a search form with filtering capabilities (text search, keywords, and frequency range), and corresponding templates and JavaScript components.
Changes:
- Added
SearchPublishedDatasetsViewandHomePageViewclasses with search and filtering functionality - Created
PublishedDatasetSearchFormfor dataset search with query, keywords, and frequency filters - Refactored existing templates to use partials for better code reuse
- Added JavaScript components for keyword chip input and dataset search handling
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
| gateway/sds_gateway/users/views.py | Added SearchPublishedDatasetsView and HomePageView classes with search filtering methods; methods duplicated from ListDatasetsView |
| gateway/sds_gateway/users/urls.py | Added URL pattern for search_datasets endpoint |
| gateway/sds_gateway/users/forms.py | Added PublishedDatasetSearchForm with query, keywords, and frequency fields |
| gateway/sds_gateway/templates/users/search_datasets.html | New template for dataset search page (has critical template variable naming bugs) |
| gateway/sds_gateway/templates/users/published_datasets_list.html | New template that includes search tab partial |
| gateway/sds_gateway/templates/users/partials/search_published_datasets_tab.html | Partial template for search results display |
| gateway/sds_gateway/templates/users/partials/my_datasets_tab.html | Refactored partial extracted from dataset_list.html |
| gateway/sds_gateway/templates/users/partials/dataset_search_form.html | Reusable search form partial (has critical form ID and duplicate name attribute bugs) |
| gateway/sds_gateway/templates/users/dataset_list.html | Refactored to use my_datasets_tab.html partial |
| gateway/sds_gateway/templates/pages/home.html | Enhanced with latest datasets display and search form (has critical JavaScript syntax error) |
| gateway/sds_gateway/static/js/search/KeywordChipInput.js | New JavaScript component for keyword chip input functionality |
| gateway/sds_gateway/static/js/search/DatasetSearchHandler.js | New JavaScript handler for dataset search interactions |
| gateway/sds_gateway/static/css/components.css | Added CSS styles for keyword chip components |
| gateway/config/urls.py | Updated home page to use new HomePageView instead of TemplateView |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gateway/sds_gateway/templates/users/partials/dataset_search_form.html
Outdated
Show resolved
Hide resolved
gateway/sds_gateway/templates/users/partials/search_published_datasets_tab.html
Show resolved
Hide resolved
|
dataset submission works now. |
No description provided.