Skip to content

Conversation

@klpoland
Copy link
Collaborator

No description provided.

@klpoland klpoland self-assigned this Jan 21, 2026
@klpoland klpoland added feature New feature or request gateway Gateway component labels Jan 21, 2026
@klpoland klpoland force-pushed the feature-kpoland-public-datasets-view branch from 2c69a33 to 9bee670 Compare January 22, 2026 14:50
@klpoland klpoland force-pushed the feature-kpoland-public-datasets-view branch from 9bee670 to b233070 Compare January 22, 2026 14:51
@klpoland klpoland marked this pull request as ready for review January 22, 2026 17:28
@klpoland klpoland requested a review from lucaspar January 22, 2026 17:28
@lucaspar lucaspar requested a review from Copilot January 22, 2026 18:20
@lucaspar lucaspar added the javascript Pull requests that update non-trivial javascript code label Jan 22, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a public datasets search feature, allowing users to discover and search published datasets without authentication. The implementation includes new view classes for searching published datasets, a search form with filtering capabilities (text search, keywords, and frequency range), and corresponding templates and JavaScript components.

Changes:

  • Added SearchPublishedDatasetsView and HomePageView classes with search and filtering functionality
  • Created PublishedDatasetSearchForm for dataset search with query, keywords, and frequency filters
  • Refactored existing templates to use partials for better code reuse
  • Added JavaScript components for keyword chip input and dataset search handling

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 11 comments.

Show a summary per file
File Description
gateway/sds_gateway/users/views.py Added SearchPublishedDatasetsView and HomePageView classes with search filtering methods; methods duplicated from ListDatasetsView
gateway/sds_gateway/users/urls.py Added URL pattern for search_datasets endpoint
gateway/sds_gateway/users/forms.py Added PublishedDatasetSearchForm with query, keywords, and frequency fields
gateway/sds_gateway/templates/users/search_datasets.html New template for dataset search page (has critical template variable naming bugs)
gateway/sds_gateway/templates/users/published_datasets_list.html New template that includes search tab partial
gateway/sds_gateway/templates/users/partials/search_published_datasets_tab.html Partial template for search results display
gateway/sds_gateway/templates/users/partials/my_datasets_tab.html Refactored partial extracted from dataset_list.html
gateway/sds_gateway/templates/users/partials/dataset_search_form.html Reusable search form partial (has critical form ID and duplicate name attribute bugs)
gateway/sds_gateway/templates/users/dataset_list.html Refactored to use my_datasets_tab.html partial
gateway/sds_gateway/templates/pages/home.html Enhanced with latest datasets display and search form (has critical JavaScript syntax error)
gateway/sds_gateway/static/js/search/KeywordChipInput.js New JavaScript component for keyword chip input functionality
gateway/sds_gateway/static/js/search/DatasetSearchHandler.js New JavaScript handler for dataset search interactions
gateway/sds_gateway/static/css/components.css Added CSS styles for keyword chip components
gateway/config/urls.py Updated home page to use new HomePageView instead of TemplateView

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@klpoland
Copy link
Collaborator Author

dataset submission works now.

@klpoland klpoland merged commit 1569200 into master Jan 27, 2026
2 checks passed
@klpoland klpoland deleted the feature-kpoland-public-datasets-view branch January 27, 2026 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request gateway Gateway component javascript Pull requests that update non-trivial javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants