feat(voice): forward custom WebSocket headers via connect()#120
Draft
sam-s10s wants to merge 1 commit into
Draft
feat(voice): forward custom WebSocket headers via connect()#120sam-s10s wants to merge 1 commit into
sam-s10s wants to merge 1 commit into
Conversation
Add optional ws_headers argument to VoiceAgentClient.connect(), forwarded to start_session (RT client already supports it). Adds header handling tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an optional
ws_headersargument toVoiceAgentClient.connect(), forwarded through tostart_session. The underlying RT client already supports custom WebSocket handshake headers; this wires the Voice SDK up to it.Changes
VoiceAgentClient.connect(ws_headers: Optional[dict] = None)→ passed tostart_session(..., ws_headers=ws_headers).test_with_headers(valid headers connect/disconnect) andtest_with_corrupted_headers(malformed headers handled gracefully) intests/voice/test_06_stt_config.py.Notes
sdk/voice/speechmatics/voice/_client.py(only theconnect()region). Two sibling PRs (pr/voice-8khz,pr/voice-forced-eou) also touch this file but in disjoint regions — they merge cleanly in any order; whichever lands later may need a trivial rebase.voice/v0.2.9-rc3pre-release line.Test plan
tests/voice/test_06_stt_config.pypasses with a valid API key