chore(voice): replace operating_point with model in voice SDK#124
Draft
sam-s10s wants to merge 3 commits into
Draft
chore(voice): replace operating_point with model in voice SDK#124sam-s10s wants to merge 3 commits into
sam-s10s wants to merge 3 commits into
Conversation
Switch VoiceAgentConfig, presets and client wiring from `operating_point` to the new `model` field (defaulting to `Model.ENHANCED`). `operating_point` is kept as a deprecated field that is automatically migrated to `model` during validation, so existing configs (including JSON) continue to work. Update docstrings, presets and tests accordingly.
sam-s10s
changed the title
The migration path appended "migrated operating_point to model" to the validation errors list, which caused every config using the deprecated `operating_point` to raise a ValueError. Emit a DeprecationWarning and migrate silently instead. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Match the RT SDK's handling of the deprecated `operating_point` field: raise a ValueError when both `model` and `operating_point` are set explicitly, and use the `from warnings import warn` style and message wording. Add a test covering migration, no-op and conflict cases. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch
VoiceAgentConfig, presets and client wiring fromoperating_pointto the newmodelfield (defaulting toModel.ENHANCED).operating_pointis kept as a deprecated field that is automatically migrated tomodelduring validation, so existing configs (including JSON) continue to work.Docstrings, presets and tests updated accordingly