docs(tests): clarify gas-cap semantics and SSTORE stub layout assumption - #13
Open
spencer-tb wants to merge 1 commit into
Open
docs(tests): clarify gas-cap semantics and SSTORE stub layout assumption#13spencer-tb wants to merge 1 commit into
spencer-tb wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Debugging PR for the ethereum#2977 follow-up, based on the upstream PR head (18b0fbb). Shows only the follow-up changes before the real PR against upstream forks/amsterdam.
tx_iterations_by_gas_limitdocstring: the tx gas-limit cap constrains compute gas; under EIP-8037 the combined gas limit may exceed it by the state-gas portion.test_sstore_bloateddocstring: restore the linear value==key stub storage layout assumption thatexisting_slots=Truegas metadata relies on.tx_iterations_by_total_iteration_count: comment why the cap also bounds combined gas (no block budget in this context; keeps the search finite, slightly under-fills under state gas).